Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] convert netflow input to API v2 #37901

Merged
merged 13 commits into from Feb 12, 2024

Conversation

pkoutsovasilis
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis commented Feb 7, 2024

Proposed commit message

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

How to test this PR locally

go test github.com/elastic/beats/v7/x-pack/filebeat/input/netflow

Related issues

@pkoutsovasilis pkoutsovasilis added Filebeat Filebeat Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution labels Feb 7, 2024
@pkoutsovasilis pkoutsovasilis requested review from a team as code owners February 7, 2024 11:37
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 7, 2024
Copy link
Contributor

mergify bot commented Feb 7, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @pkoutsovasilis? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 7, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-02-12T14:10:57.588+0000

  • Duration: 10 min 7 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Feb 9, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
x-pack/filebeat/input/netflow/input.go Outdated Show resolved Hide resolved
x-pack/filebeat/input/netflow/input.go Outdated Show resolved Hide resolved
x-pack/filebeat/input/netflow/input.go Outdated Show resolved Hide resolved
x-pack/filebeat/input/netflow/input_test.go Outdated Show resolved Hide resolved
x-pack/filebeat/input/netflow/netflow_test.go Outdated Show resolved Hide resolved
x-pack/filebeat/input/netflow/netflow_test.go Outdated Show resolved Hide resolved
x-pack/filebeat/input/netflow/netflow_test.go Outdated Show resolved Hide resolved
x-pack/filebeat/input/netflow/netflow_test.go Outdated Show resolved Hide resolved
x-pack/filebeat/input/netflow/netflow_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

mergify bot commented Feb 12, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b pkoutsovasilis/netflow_v2 upstream/pkoutsovasilis/netflow_v2
git merge upstream/main
git push upstream pkoutsovasilis/netflow_v2

Copy link
Contributor

@belimawr belimawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pkoutsovasilis could you take a look at merge conflicts?

@pkoutsovasilis
Copy link
Contributor Author

LGTM.

@pkoutsovasilis could you take a look at merge conflicts?

@belimawr all conflicts should be resolved now

# Conflicts:
#	x-pack/filebeat/input/default-inputs/inputs_other.go
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @pkoutsovasilis

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @pkoutsovasilis

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @pkoutsovasilis

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @pkoutsovasilis

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @pkoutsovasilis

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @pkoutsovasilis

@taylor-swanson
Copy link
Contributor

/test

@pkoutsovasilis pkoutsovasilis merged commit 51745a0 into elastic:main Feb 12, 2024
50 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Filebeat Filebeat Team:Elastic-Agent Label for the Agent team Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Filebeat] Netflow input - convert to input API v2 [Filebeat] Netflow input - disable event normalization
6 participants