Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RSA2ELK deprecated modules #38037

Merged

Conversation

pkoutsovasilis
Copy link
Contributor

Proposed commit message

This PR removes all the deprecated modules in 8.12 and targets 8.14

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 15, 2024
Copy link
Contributor

mergify bot commented Feb 15, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @pkoutsovasilis? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 15, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-04-15T13:19:43.118+0000

  • Duration: 142 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 8453
Skipped 773
Total 9226

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@taylor-swanson taylor-swanson added Filebeat Filebeat backport-skip Skip notification from the automated backport with mergify Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution labels Mar 18, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 18, 2024
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @pkoutsovasilis

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @pkoutsovasilis

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @pkoutsovasilis

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @pkoutsovasilis

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @pkoutsovasilis

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @pkoutsovasilis

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @pkoutsovasilis

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 19, 2024

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 19, 2024

@taylor-swanson taylor-swanson marked this pull request as ready for review March 20, 2024 13:07
@taylor-swanson taylor-swanson requested review from a team as code owners March 20, 2024 13:07
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@taylor-swanson
Copy link
Contributor

Pinging @elastic/obs-infraobs-integrations and @elastic/sec-windows-platform for a review.

@taylor-swanson
Copy link
Contributor

We are still waiting on reviews from @elastic/obs-infraobs-integrations and @elastic/sec-windows-platform.

cc @nfritts @norrietaylor @lalit-satapathy

Copy link
Contributor

mergify bot commented Apr 15, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b pkoutsovasilis/cleanup_rsa2elk upstream/pkoutsovasilis/cleanup_rsa2elk
git merge upstream/main
git push upstream pkoutsovasilis/cleanup_rsa2elk

@pkoutsovasilis pkoutsovasilis merged commit 502a30b into elastic:main Apr 15, 2024
45 of 55 checks passed
@pkoutsovasilis pkoutsovasilis deleted the pkoutsovasilis/cleanup_rsa2elk branch April 15, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify Filebeat Filebeat Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RSA2ELK] Remove deprecated modules
7 participants