Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/filebeat/input/httpjson: drop response bodies at end of execution #38116

Merged
merged 1 commit into from Feb 23, 2024

Commits on Feb 22, 2024

  1. x-pack/filebeat/input/httpjson: drop response bodies at end of execution

    The response bodies of the first and last responses were being held in a
    closed-over variable resulting in high static memory loads in some
    situations. The bodies are not used between periodic executions with the
    documentation stating that only cursor values are persisted across
    restarts. The difference in behaviour between using the body field over
    a restart versus over a sequence of executions in the same run make them
    unsafe, so clarify the persistence behaviour in the documentation and
    free the bodies at the end of an execution.
    
    A survey of integrations that use the httpjson input did not identify
    any that are using behaviour that is being removed, but we will need to
    keep an eye on cases that may have been missed. In general, if
    persistence is being depended on, the cursor should be being used.
    efd6 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    b4179cf View commit details
    Browse the repository at this point in the history