Enhancements of the cherrypick PRs script #3848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
reviewed
Mar 30, 2017
| @@ -135,6 +135,9 @@ def main(): | |||
| session.post( | |||
| base + "/issues/{}/labels".format(new_pr["number"]), json=["backport", "review"]) | |||
|
|
|||
| # remove needs backport label from the original PR | |||
| session.delete(base + "/issues/{}/labels/needs_backport".format(args.pr_number)) | |||
There was a problem hiding this comment.
My only two concern with this is that the label should only be removed, when the PR is merged. And it also does not work if their are backports needed to 5.3 and 5.4
There was a problem hiding this comment.
I agree it's not ideal. In case we need to backport a PR to multiple branches, then it would be nice to enhance the script to be able to pass a list of branches instead of one, and then remove the needs_backport, but this is for another PR.
|
LGTM. See my comment above. I think it's more an edge case and more often it works then it doesn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
needs_backportlabel from the original PR once the backport PR was opened