Cherry-pick #3879 to master: Fix modules yml files permission on Deb #3893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
reviewed
Apr 4, 2017
CHANGELOG.asciidoc
Outdated
| @@ -19,6 +19,66 @@ https://github.com/elastic/beats/compare/v5.1.1...master[Check the HEAD diff] | |||
| they must not be writable by others. {pull}3544[3544] {pull}3689[3689] | |||
| - Usage of field `_type` is now ignored and hardcoded to `doc`. {pull}3757[3757] | |||
| - Change vendor manager from glide to govendor {pull}3851[3851] | |||
| *Filebeat* | |||
There was a problem hiding this comment.
@tsg is the addition of all these changelog entries on purpose?
The fix in elastic#3645 had a bug (chmod executed on the wrong folder). This fixes the fix and also adds permissions checks to the tests. (cherry picked from commit 37ae2fc)
tsg
force-pushed
the
backport_3879_master
branch
from
3b1e410
to
cff7672
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #3879 to master branch. Original message:
The fix in #3645 had a bug (chmod executed on the wrong folder). This fixes the fix and also adds permissions checks to the tests.