Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/filebeat/input/entityanalytics - Fix log format #38990

Merged

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Apr 16, 2024

Proposed commit message

Change logger statements to not use %w (which is only for wrapping in fmt.Errorf).

Users reported seeing messages like:

Failed to obtain some registered user data: %!w(*fmt.wrapError=&{unable to fetch users: unexpected status code: 404 body

And fix documentation links for device and groups.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related

@andrewkroh andrewkroh added Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team labels Apr 16, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 16, 2024
Copy link
Contributor

mergify bot commented Apr 16, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @andrewkroh? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@andrewkroh andrewkroh force-pushed the bugfix/fb/entity-analytics-log-fmt branch from eefd464 to 348e79a Compare April 16, 2024 18:43
Change logger statements to not use `%w` (which is only for
wrapping in fmt.Errorf).

Users reported seeing messages like:

    Failed to obtain some registered user data: %!w(*fmt.wrapError=&{unable to fetch users: unexpected status code: 404 body

This comment was marked as outdated.

@andrewkroh andrewkroh force-pushed the bugfix/fb/entity-analytics-log-fmt branch from 348e79a to 10ff202 Compare April 16, 2024 18:44
@andrewkroh andrewkroh added backport-skip Skip notification from the automated backport with mergify bug labels Apr 16, 2024
@andrewkroh andrewkroh marked this pull request as ready for review April 16, 2024 18:44
@andrewkroh andrewkroh requested a review from a team as a code owner April 16, 2024 18:44
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 16, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 120 min 0 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
@andrewkroh andrewkroh enabled auto-merge (squash) April 16, 2024 21:54
Copy link
Contributor

mergify bot commented Apr 16, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b bugfix/fb/entity-analytics-log-fmt upstream/bugfix/fb/entity-analytics-log-fmt
git merge upstream/main
git push upstream bugfix/fb/entity-analytics-log-fmt

@andrewkroh andrewkroh merged commit eb122ef into elastic:main Apr 17, 2024
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify bug Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants