Don't stop Filebeat when modules + logstash are used together #3929
Conversation
tsg
added
needs_backport
|
@dedemorton This is the PR to make FBM continue if only the Logstash output is configured, with a warning. Can you review the warn message? I was thinking we could even link to a longer explanation in the docs. |
filebeat/beater/filebeat.go
Outdated
| @@ -75,7 +75,10 @@ func New(b *beat.Beat, rawConfig *common.Config) (beat.Beater, error) { | |||
| func (fb *Filebeat) modulesSetup(b *beat.Beat) error { | |||
| esConfig := b.Config.Output["elasticsearch"] | |||
| if esConfig == nil || !esConfig.Enabled() { | |||
| return fmt.Errorf("Filebeat modules configured but the Elasticsearch output is not configured/enabled") | |||
| logp.Warn("Filebeat modules enabled but the Elasticsearch output is not configured/enabled." + | |||
| " This means I can't load the Ingest Node pipelines." + | |||
There was a problem hiding this comment.
I stumbled over the I and would replace it by Filebeat
tsg
force-pushed
the
no_error_on_fbm_and_logstash
branch
from
daf41b7
to
061174c
Compare
|
jenkins, retest it |
| @@ -75,7 +75,10 @@ func New(b *beat.Beat, rawConfig *common.Config) (beat.Beater, error) { | |||
| func (fb *Filebeat) modulesSetup(b *beat.Beat) error { | |||
| esConfig := b.Config.Output["elasticsearch"] | |||
| if esConfig == nil || !esConfig.Enabled() { | |||
| return fmt.Errorf("Filebeat modules configured but the Elasticsearch output is not configured/enabled") | |||
There was a problem hiding this comment.
LGTM (couple of minor changes)
Filebeat modules are enabled, but the Elasticsearch output is not configured/enabled. This means Filebeat can't load the Ingest Node pipelines. If you have already loaded the pipelines, you can ignore this warning.
Not sure if this covers LS users, tho, because they really don't need to load the pipelines at all, right?
There was a problem hiding this comment.
An alternate version (in case you want to shift the focus away from the idea that ES is required):
Filebeat is unable to load the Ingest Node pipelines for the configured modules because the Elasticsearch output is not configured/enabled. If you have already loaded the Ingest Node pipelines or are using Logstash pipelines, you can ignore this warning.
To simplify the migration from Ingest Node to Logstash, we replace the
hard error ("Filebeat modules require an Elasticsearch output defined") with
a warning.
tsg
force-pushed
the
no_error_on_fbm_and_logstash
branch
from
061174c
to
890ef36
Compare
|
@dedemorton thanks, i used your second version. |
To simplify the migration from Ingest Node to Logstash, we replace the
hard error ("Filebeat modules require an Elasticsearch output defined") with
a warning.