Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auditbeat: align Buildkite steps to match Jenkins #39568

Merged
merged 3 commits into from
May 15, 2024

Conversation

oakrizan
Copy link
Contributor

@oakrizan oakrizan commented May 15, 2024

Proposed commit message

  1. Updated auditbeat pipeline to match same steps & commands as in Jenkins on 7.17 branch
  2. Removed dynamic pipeline generation script generate_auditbeat_pipeline.sh - leftover, not required anymore, deleted from main as well.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • .buildkite/auditbeat/auditbeat-pipeline.yml

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Buildkite builds: https://buildkite.com/elastic/auditbeat/builds?branch=oakrizan%3Aaligning-auditbeat-with-7-17

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 15, 2024
@oakrizan oakrizan force-pushed the aligning-auditbeat-with-7-17 branch from d59b3bd to ac71a5e Compare May 15, 2024 09:30
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 15, 2024
@oakrizan oakrizan marked this pull request as ready for review May 15, 2024 09:47
@oakrizan oakrizan requested a review from a team as a code owner May 15, 2024 09:47
Copy link
Contributor

mergify bot commented May 15, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b aligning-auditbeat-with-7-17 upstream/aligning-auditbeat-with-7-17
git merge upstream/7.17
git push upstream aligning-auditbeat-with-7-17

Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oakrizan oakrizan merged commit a52cafc into elastic:7.17 May 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants