Bring back prospector.type which went missing #4361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vjsamuel As you are working off master, this could interest you. |
|
@ruflin, i did notice that |
glefloch
approved these changes
May 22, 2017
| filebeat.check_kill_and_wait() | ||
|
|
||
| output = self.read_output()[0] | ||
| assert "@timestamp" in output |
There was a problem hiding this comment.
Shouldn't we assert that prospector.type is in the output ?
There was a problem hiding this comment.
YES. I'm not really confused to not see it here, because that is the reason I added this test. Not sure what I was doing. Thanks for spotting this.
It seems in one of the recent refactorings prospector.type went missing. Test added to make sure it will not go missing again.
ruflin
force-pushed
the
bring-back-prospector-type
branch
from
32349bc
to
47cf36f
Compare
andrewkroh
reviewed
May 22, 2017
| Test if the basic fields exist. | ||
| """ | ||
| self.render_config_template( | ||
| path=os.path.abspath(self.working_dir) + "/test.log", |
There was a problem hiding this comment.
After dealing with weird path issues lately, I recommend using os.path.join over string concat to join paths. Or even just putting the + "/test.log" inside the abspath() call would fix the problem because abspath normalizes the path that it returns.
andrewkroh
approved these changes
May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems in one of the recent refactorings prospector.type went missing. Test added to make sure it will not go missing again.