Add normalized CPU values and number of cores #4553
Conversation
metricbeat/metricbeat.full.yml
Outdated
| # if true, exports the CPU usage in ticks, together with the percentage values | ||
| #cpu_ticks: false | ||
| # Configure the metric types that are included by these metricsets. | ||
| cpu.metrics: [percentages] # The other available options are normalized_percentages and ticks. |
There was a problem hiding this comment.
Should we add "quotes" around percentages? Seems we do this everywhere else with strings.
There was a problem hiding this comment.
I added the quotes for consistency. 3b23220
| "idle": { | ||
| "pct": 0.9063, | ||
| "ticks": 22204290 | ||
| "pct": 0, |
There was a problem hiding this comment.
If you run it 2-3 more times, you should also get some values for the pct.
| // Config for the system core metricset. | ||
| type Config struct { | ||
| Metrics []string `config:"core.metrics"` | ||
| CPUTicks *bool `config:"cpu_ticks"` // Deprecated. |
There was a problem hiding this comment.
Should we deprecate it in 5.6 and remove it here?
There was a problem hiding this comment.
@ruflin Any reason to deprecate it in 5.6 instead of 6.0.0?
There was a problem hiding this comment.
I don't like deprecated features in the code base. If don't do it now, we have to wait until 7.0 to remove it. Seems like a good time to do it now. Any disadvantage doing it now?
There was a problem hiding this comment.
Does it make sense to add deprecation warnings in 5.6 when there is no replacement for cpu_ticks in 5.6? I thought there should be some period of overlap where the two config options are available to aid in migration.
There was a problem hiding this comment.
I meant 5.6. But possibly I misunderstood the original suggestion. You were suggesting adding the deprecation warnings in 5.6 and not having a migration path in 5.6 (e.g. we are telling the user not to use cpu_ticks, but not offering them an alternative in 5.6)?
| // Validate validates the cpu config. | ||
| func (c Config) Validate() error { | ||
| if c.CPUTicks != nil { | ||
| logp.Deprecate("6.0.0", "cpu_ticks is deprecated. Add 'ticks' to the cpu.metrics list.") |
|
Merged #4550, can you rebase this one, please? The flaky container failures in Metricbeat/travis should also be fixed after rebase. |
Remove the arguments and use a constant to control the maximum number of decimal places.
andrewkroh
force-pushed
the
bugfix/6-0-cpu-normalization
branch
2 times, most recently
from
e86be9d
to
84e718f
Compare
|
I rebased the PR to resolve the conflicts, and squashed the commits where I addressed action items because I think it would be best to "Rebase and merge" this PR. |
- Added normalized CPU metrics for core, cpu, and process metricsets that are divided by the number of CPU cores. - Refactored helper code used by core, cpu, and load metricsets. - Deprecated use of `cpu_ticks` in favor of per metricset settings.
andrewkroh
force-pushed
the
bugfix/6-0-cpu-normalization
branch
from
84e718f
to
979091f
Compare
This include the contents of #4550 (so merge that first and the amount to review will be smaller).
cpu_ticksin favor of per metricset settings.