Introduce BEAT_INDEX_PREFIX #5110
Conversation
This allows applications relying on libbeat to override the index pattern generated. BEAT_INDEX_PREFIX defaults to `BEAT_NAME-*`.
roncohen
force-pushed
the
allow-index-prefix-override
branch
from
6259b3a
to
59b7021
Compare
simitt
force-pushed
the
allow-index-prefix-override
branch
from
662ce9e
to
c4cdc25
Compare
There was a problem hiding this comment.
In general I like this change as it adds more flexibility to set different default index names for community beats.
To keep in mind, dhe default inside beats is still the same. We probably should also allow to overwrite these somehow. The reason that I think this is also required is that the filebeat.yml file for example does not contain the index pattern, so the default one will be taken.
@tsg Could you think of other issues?
@roncohen Can you rebase this on master and squash this PR? Please also check the generator build on travis. It failed before because of some download issue. I think it should go green, but double check it.
| @@ -155,10 +155,10 @@ output.elasticsearch: | |||
| # Number of workers per Elasticsearch host. | |||
| #worker: 1 | |||
|
|
|||
| # Optional index name. The default is "beatname" plus date | |||
| # and generates [beatname-]YYYY.MM.DD keys. | |||
| # Optional index name. The default is "index-prefix" plus date | |||
There was a problem hiding this comment.
should we call it beat-index-prefix to make sure index-prefix is not used anywhere else and be in sync with the variable name in the Makefile?
|
I work on a follow up PR that includes also change the default inside beats, see #5161 |
|
Closing as #5161 covered this work I think. |
This allows applications relying on libbeat to override the index pattern generated.
BEAT_INDEX_PREFIX defaults to BEAT_NAME.