Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure VM support for add_cloud_metadata processor #5355

Merged
merged 5 commits into from Oct 10, 2017

Conversation

saada
Copy link
Contributor

@saada saada commented Oct 7, 2017

@elasticmachine
Copy link
Collaborator

Can one of the admins verify this patch?

@saada saada changed the title Add Azure VM Cloud Metadata Support Add Azure VM support for add_cloud_metadata processor Oct 7, 2017
@ruflin
Copy link
Member

ruflin commented Oct 9, 2017

Thanks a lot for this contribution. Could you adda CHANGELOG entry?

@ruflin
Copy link
Member

ruflin commented Oct 9, 2017

jenkins, test it

@saada
Copy link
Contributor Author

saada commented Oct 9, 2017

Thanks @ruflin, where do I add the change log? Under rc1 notes?

@ruflin
Copy link
Member

ruflin commented Oct 9, 2017

@saada Best add it after - Add support for enabling TLS renegotiation. {issue}4386[4386].

@saada
Copy link
Contributor Author

saada commented Oct 9, 2017

@ruflin I don't see that entry in the changelog.

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@andrewkroh
Copy link
Member

@saada Have a look at the raw view of the CHANGELOG file.

@saada
Copy link
Contributor Author

saada commented Oct 9, 2017

🎉 Done!

@andrewkroh
Copy link
Member

I just thought of one more thing we need with this change. Can you update the add_cloud_metadata docs to include Azure.

@saada
Copy link
Contributor Author

saada commented Oct 9, 2017

@andrewkroh done 👍

@ruflin
Copy link
Member

ruflin commented Oct 10, 2017

jenkins, test it

@andrewkroh andrewkroh merged commit 483982b into elastic:master Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants