Add kubernetes autodiscover docs #6065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
vjsamuel
force-pushed
the
kube_autodocs
branch
from
2700abc
to
c78ef40
Compare
exekias
reviewed
Jan 15, 2018
CHANGELOG.asciidoc
Outdated
| @@ -130,6 +130,7 @@ https://github.com/elastic/beats/compare/v6.0.0-beta2...master[Check the HEAD di | |||
| - Add the ability to log to the Windows Event Log. {pull}5913[5813] | |||
| - Improve Elasticsearch output metrics to count number of dropped and duplicate (if event ID is given) events. {pull}5811[5811] | |||
| - Add autodiscover for kubernetes. {pull}6055[6055] | |||
| - Add kubernetes autodiscover docs {pull}6065[6065] | |||
There was a problem hiding this comment.
there is no need for this line this time, as Add autodiscover for kubernetes is already there :)
exekias
reviewed
Jan 15, 2018
| templates: | ||
| - condition: | ||
| contains: | ||
| kubernetes.labels.project: "prometheus" |
There was a problem hiding this comment.
This is a very good example for the configuration! Perhaps we should use the prometheus.io.scrape: "true" annotation?
|
Thank you for taking this @vjsamuel, I left some comments |
vjsamuel
force-pushed
the
kube_autodocs
branch
from
c78ef40
to
fdca86b
Compare
|
@exekias done |
|
ok to test |
This was referenced Jan 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.