Metricbeat/RabbitMQ: Adds connections metricset #6458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
houndci-bot
reviewed
Feb 23, 2018
| assert.EqualValues(t, 376, packet_count["receive"]) | ||
| assert.EqualValues(t, 0, packet_count["pending"]) | ||
|
|
||
| octet_count := event["octet_count"].(common.MapStr) |
There was a problem hiding this comment.
don't use underscores in Go names; var octet_count should be octetCount
| assert.EqualValues(t, 131072, event["frame_max"]) | ||
| assert.EqualValues(t, "network", event["type"]) | ||
|
|
||
| packet_count := event["packet_count"].(common.MapStr) |
There was a problem hiding this comment.
don't use underscores in Go names; var packet_count should be packetCount
| mbtest "github.com/elastic/beats/metricbeat/mb/testing" | ||
| ) | ||
|
|
||
| func TestData(t *testing.T) { |
There was a problem hiding this comment.
exported function TestData should have comment or be unexported
| }, nil | ||
| } | ||
|
|
||
| func (m *MetricSet) Fetch() ([]common.MapStr, error) { |
There was a problem hiding this comment.
exported method MetricSet.Fetch should have comment or be unexported
| *helper.HTTP | ||
| } | ||
|
|
||
| func New(base mb.BaseMetricSet) (mb.MetricSet, error) { |
There was a problem hiding this comment.
exported function New should have comment or be unexported
| } | ||
| } | ||
|
|
||
| type MetricSet struct { |
There was a problem hiding this comment.
exported type MetricSet should have comment or be unexported
ruflin
reviewed
Feb 26, 2018
| type: keyword | ||
| description: > | ||
| Server hostname obtained via reverse DNS, or its IP address if reverse DNS failed or was disabled. | ||
| - name: peer_host |
There was a problem hiding this comment.
Can we make this peer.host and `peer.port?
| } | ||
|
|
||
| func New(base mb.BaseMetricSet) (mb.MetricSet, error) { | ||
| cfgwarn.Experimental("The rabbitmq connection metricset is experimental") |
There was a problem hiding this comment.
Somehow docs and code do not align here. In the docs it's marked as beta. I assume that has to do with our generator :-( Could you change this to cfgwarn.Beta here?
|
@jaipradeesh One more thing, you could update the PR description with some more descriptive details? |
|
jenkins, test it |
|
To update the auto generated files you need to run |
dolftax
force-pushed
the
metricbeat-rabbitmq-connections
branch
from
da78b18
to
28e0c18
Compare
|
dolftax
force-pushed
the
metricbeat-rabbitmq-connections
branch
from
28e0c18
to
aca9c0a
Compare
|
dolftax
force-pushed
the
metricbeat-rabbitmq-connections
branch
from
aca9c0a
to
a5237e6
Compare
@ruflin Help. |
|
I think the problem is that you forked the project under |
|
Parallel fork. Fixing. Update: http://dpaste.com/3B6W174 |
|
I assume |
|
Update: Removing the above line from |
dolftax
force-pushed
the
metricbeat-rabbitmq-connections
branch
from
a5237e6
to
c374fcd
Compare
|
There should not be a directory |
|
Removed. Generating JSON. It might take a while. |
|
You can temporarely adjust the line to or even as following to gather data from a local rabbitmq instance you have running: |
Following metrics are added: name - The name of the connection with non-ASCII characters escaped as in C. vhost - Virtual host name with non-ASCII characters escaped as in C. user - User name. node - Node name. channels - The number of channels on the connection. channel_max - The maximum number of channels allowed on the connection. frame_max - Maximum permissible size of a frame (in bytes) to negotiate with clients. type - Type of the connection. host - Server hostname obtained via reverse DNS, or its IP address if reverse DNS failed or was disabled. peer_host - Peer hostname obtained via reverse DNS, or its IP address if reverse DNS failed or was not enabled. peer_port - Peer port. server_port - Server port. packet_count - Number of packets sent, received and pending on the connection. octet_count - Number of octets sent and received on the connection. Signed-off-by: Jaipradeesh <jaipradeesh@gmail.com>
dolftax
force-pushed
the
metricbeat-rabbitmq-connections
branch
from
c374fcd
to
9c133af
Compare
|
@ruflin LGTM. Thanks for the help with onboarding. Let me know. |
|
jenkins, test it |
|
@jaipradeesh Thanks for going through this. It's a pleasure to work like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following metrics are added:
name - The name of the connection with non-ASCII characters escaped as in C.
vhost - Virtual host name with non-ASCII characters escaped as in C.
user - User name.
node - Node name.
channels - The number of channels on the connection.
channel_max - The maximum number of channels allowed on the connection.
frame_max - Maximum permissible size of a frame (in bytes) to negotiate with clients.
type - Type of the connection.
host - Server hostname obtained via reverse DNS, or its IP address if reverse DNS failed or was disabled.
peer_host - Peer hostname obtained via reverse DNS, or its IP address if reverse DNS failed or was not enabled.
peer_port - Peer port.
server_port - Server port.
packet_count - Number of packets sent, received and pending on the connection.
octet_count - Number of octets sent and received on the connection.
Signed-off-by: Jaipradeesh jaipradeesh@gmail.com