Start simplify system tests #6906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires parameterized on the windows workers. I opened a PR for the changes. |
ruflin
force-pushed
the
simplify-tests
branch
3 times, most recently
from
1d372b4
to
ca73d74
Compare
ruflin
commented
Apr 30, 2018
| @@ -65,7 +65,7 @@ def assert_no_logged_warnings(self, replace=None): | |||
| """ | |||
| log = self.get_log() | |||
|
|
|||
| pattern = self.build_log_regex("[cfgwarn]") | |||
| pattern = self.build_log_regex("\[cfgwarn\]") | |||
There was a problem hiding this comment.
This was actually a bug in our code and removed all WARN and ERROR entries from the log :-(
The idea of this PR is to start to play around with ways to simplify our system tests are remove most of the duplicated code. * Use check_metricset method for aerospike test * Add fields check to check_metricset method * Use parameterized for ceph and couchbase tests Further fixes: * Increase timeout for k8s tests * Fix regexp to remove cfgwarn warnings. The removal removed all WARN / ERROR messages. * Fix flaky auditbeat test by skipping the error message.
jsoriano
reviewed
Apr 30, 2018
| self.assertTrue("pool_disk" in evt["ceph"]) | ||
|
|
||
| self.assert_fields_are_documented(evt) | ||
| self.check_metricset("ceph", metricset, self.get_hosts(), self.FIELDS) |
jsoriano
approved these changes
Apr 30, 2018
|
jenkins, test this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of this PR is to start to play around with ways to simplify our system tests are remove most of the duplicated code.
Further fixes: