Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for RFC3339 timestamp and nanoseconds parsing #7046

Merged
merged 2 commits into from May 9, 2018

Conversation

ph
Copy link
Contributor

@ph ph commented May 8, 2018

Syslog formatted events format sometime differ from the official specs,
it's possible to receive timestamp formatted using RFC3339.

This commits fixes a few things:

  • Correctly support the 2018-05-08T10:31:24 format;
  • Fix nanosecond parsing to respect the actual numerical representation
    (microsecond vs. nanosecond)
  • Fix an issue when partial Syslog events sent to the publisher,
    now when invalid message is received we send the raw format.

@ph ph added review Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. labels May 8, 2018
@ph ph force-pushed the fix/timestamp-rfc3339 branch from bc57b5b to b5ad78f Compare May 8, 2018 19:39
ph added 2 commits May 8, 2018 15:48
Syslog formatted events format sometime differ from the official specs,
it's possible to receive timestamp formatted using RFC3339.

This commits fixes a few things:

- Correctly support the 2018-05-08T10:31:24 format;
- Fix nanosecond parsing to respect the actual numerical representation
(microsecond vs. nanosecond)
- Fix an issue when partial Syslog events sent to the publisher,
now when invalid message is received we send the raw format.
@ph ph force-pushed the fix/timestamp-rfc3339 branch from b5ad78f to 5eed3e4 Compare May 8, 2018 19:48
@ph
Copy link
Contributor Author

ph commented May 8, 2018

jenkins tests this please

@ph
Copy link
Contributor Author

ph commented May 8, 2018

jenkins test this please

Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be good if a @kvch would also have a look at this one.

@kvch kvch merged commit 5bcbe85 into elastic:master May 9, 2018
@kvch
Copy link
Contributor

kvch commented May 9, 2018

Thanks for fixing it quickly.

@ph ph added v6.3.0 and removed needs_backport PR is waiting to be backported to other branches. labels May 9, 2018
ph added a commit to ph/beats that referenced this pull request May 9, 2018
)

* Adds support for RFC3339 timestamp

Syslog formatted events format sometime differ from the official specs,
it's possible to receive timestamp formatted using RFC3339.

This commits fixes a few things:

- Correctly support the 2018-05-08T10:31:24 format;
- Fix nanosecond parsing to respect the actual numerical representation
(microsecond vs. nanosecond)
- Fix an issue when partial Syslog events sent to the publisher,
now when invalid message is received we send the raw format.

* Update changelog

(cherry picked from commit 5bcbe85)
ruflin pushed a commit that referenced this pull request May 11, 2018
…7063)

* Adds support for RFC3339 timestamp

Syslog formatted events format sometime differ from the official specs,
it's possible to receive timestamp formatted using RFC3339.

This commits fixes a few things:

- Correctly support the 2018-05-08T10:31:24 format;
- Fix nanosecond parsing to respect the actual numerical representation
(microsecond vs. nanosecond)
- Fix an issue when partial Syslog events sent to the publisher,
now when invalid message is received we send the raw format.

* Update changelog

(cherry picked from commit 5bcbe85)
stevea78 pushed a commit to stevea78/beats that referenced this pull request May 20, 2018
)

* Adds support for RFC3339 timestamp

Syslog formatted events format sometime differ from the official specs,
it's possible to receive timestamp formatted using RFC3339.

This commits fixes a few things:

- Correctly support the 2018-05-08T10:31:24 format;
- Fix nanosecond parsing to respect the actual numerical representation
(microsecond vs. nanosecond)
- Fix an issue when partial Syslog events sent to the publisher,
now when invalid message is received we send the raw format.

* Update changelog
stevea78 pushed a commit to stevea78/beats that referenced this pull request May 20, 2018
)

* Adds support for RFC3339 timestamp

Syslog formatted events format sometime differ from the official specs,
it's possible to receive timestamp formatted using RFC3339.

This commits fixes a few things:

- Correctly support the 2018-05-08T10:31:24 format;
- Fix nanosecond parsing to respect the actual numerical representation
(microsecond vs. nanosecond)
- Fix an issue when partial Syslog events sent to the publisher,
now when invalid message is received we send the raw format.

* Update changelog
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
) (elastic#7063)

* Adds support for RFC3339 timestamp

Syslog formatted events format sometime differ from the official specs,
it's possible to receive timestamp formatted using RFC3339.

This commits fixes a few things:

- Correctly support the 2018-05-08T10:31:24 format;
- Fix nanosecond parsing to respect the actual numerical representation
(microsecond vs. nanosecond)
- Fix an issue when partial Syslog events sent to the publisher,
now when invalid message is received we send the raw format.

* Update changelog

(cherry picked from commit a9616bd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants