Add x-pack data for Elasticsearch shard metricset #7097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
in progress
houndci-bot
reviewed
May 15, 2018
| @@ -124,3 +131,24 @@ func fetchPath(http *helper.HTTP, uri, path string) ([]byte, error) { | |||
| http.SetURI(u.String()) | |||
| return http.FetchContent() | |||
| } | |||
|
|
|||
| func GetNodeInfo(http *helper.HTTP, uri string, nodeID string) (*NodeInfo, error) { | |||
There was a problem hiding this comment.
exported function GetNodeInfo should have comment or be unexported
| @@ -17,6 +17,13 @@ type Info struct { | |||
| ClusterID string `json:"cluster_uuid"` | |||
| } | |||
|
|
|||
| type NodeInfo struct { | |||
There was a problem hiding this comment.
exported type NodeInfo should have comment or be unexported
ruflin
commented
May 15, 2018
| "node": c.Str("node"), | ||
| "index": c.Str("index"), | ||
| "shard": c.Int("shard"), | ||
| "relocating_node": c.Str("relocating_node"), |
There was a problem hiding this comment.
@pickypg This value is most of the time null. In these cases metricbeat just skips the value instead of sending null. Is that ok?
39 tasks
ruflin
commented
May 16, 2018
| "host": nodeInfo.Host, | ||
| "transport_address": nodeInfo.TransportAddress, | ||
| "ip": nodeInfo.IP, | ||
| // This seems to be in the x-pack data a subset of the cluster_uuid not the name? |
There was a problem hiding this comment.
@pickypg Should this be a subest of the cluster_uuid?
ruflin
commented
May 16, 2018
|
|
||
| // This is currently needed because the cluser_uuid is `na` in stateData in case not the full state is requested. | ||
| // This needs to be brought up with the ES team. | ||
| clusterID, err := elasticsearch.GetClusterID(m.HTTP, m.HostData().SanitizedURI+statePath, stateData.MasterNode) |
There was a problem hiding this comment.
@pickypg @tlrx You might now more here? On ES master the following request http://localhost:9200/_cluster/state/version,master_node,routing_table?pretty returns:
{
"cluster_name" : "elasticsearch",
"compressed_size_in_bytes" : 36170,
"cluster_uuid" : "_na_",
"version" : 59,
If I fetch http://localhost:9200/_cluster/state/?pretty I get
{
"cluster_name" : "elasticsearch",
"compressed_size_in_bytes" : 36170,
"cluster_uuid" : "Ir3Dhzo-TluhYWEaz4UZlA",
"version" : 59,
Is this a bug?
There was a problem hiding this comment.
Good catch @ruflin
I created elastic/elasticsearch#30656 and asked Chris to review it.
ruflin
force-pushed
the
shard-xpack
branch
2 times, most recently
from
eb9dd0f
to
0d5ecec
Compare
ruflin
changed the title
* Introduces GetNodeInfo method to fetch additional info about the node. This should become obsolete in the future. * Refactor shard metricset to use module level hostParser and metricset. The xpack feature works but will need further testing with new builds of Elasticsearch. The plan is to test all xpack metricsets together when they are all done and do further tweaks.
ruflin
added
review
and removed
in progress
jsoriano
approved these changes
May 17, 2018
stevea78
pushed a commit
to stevea78/beats
that referenced
this pull request
May 20, 2018
* Introduces GetNodeInfo method to fetch additional info about the node. This should become obsolete in the future. * Refactor shard metricset to use module level hostParser and metricset. The xpack feature works but will need further testing with new builds of Elasticsearch. The plan is to test all xpack metricsets together when they are all done and do further tweaks.
stevea78
pushed a commit
to stevea78/beats
that referenced
this pull request
May 20, 2018
* Introduces GetNodeInfo method to fetch additional info about the node. This should become obsolete in the future. * Refactor shard metricset to use module level hostParser and metricset. The xpack feature works but will need further testing with new builds of Elasticsearch. The plan is to test all xpack metricsets together when they are all done and do further tweaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The xpack feature works but will need further testing with new builds of Elasticsearch. The plan is to test all xpack metricsets together when they are all done and do further tweaks.