-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xpack data structure for Elasticsearch index_summary metricset #7102
Conversation
@@ -0,0 +1,99 @@ | |||
package index_summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't use an underscore in package name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we configure hound rules to ignore this? :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice. Not sure how hound exaclty works / is configured TBH ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this cannot be configured 😕 reasons: golang/lint#209
7622e1d
to
ee0e680
Compare
* Add ID to node info and make an empty node ID possible
a68b4e1
to
6493bcd
Compare
event.RootFields.Put("type", "indices_stats") | ||
event.RootFields.Put("source_node", sourceNode) | ||
|
||
event.Index = ".monitoring-es-6-mb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This 6
is related to the version? Could we extract it from somewhere else so we don't forget to update it in 7.0? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only temporary and is the same across all metricsets for now. We have to come up with something better in the long run. Would keep it for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
event.RootFields.Put("indices_stats._all", fields) | ||
event.RootFields.Put("cluser_uuid", info.ClusterID) | ||
event.RootFields.Put("timestamp", common.Time(time.Now())) | ||
event.RootFields.Put("interval_ms", m.Module().Config().Period.Nanoseconds()/1000/1000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m.Module().Config().Period/time.Millisecond
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.