Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update field naming for Elasticsearch slowlog fileset #7556

Merged
merged 1 commit into from Jul 11, 2018

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Jul 10, 2018

Bring it in line with Metricbeat and ECS to allow correlation.

Copy link
Member

@radoondas radoondas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment

"elasticsearch.slowlog.logger": "index.search.slowlog.query",
"elasticsearch.slowlog.loglevel": "INFO",
"elasticsearch.slowlog.node_name": "v_VJhjV",
"elasticsearch.slowlog.search_type": "QUERY_THEN_FETCH",
"elasticsearch.slowlog.shard_id": "0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shard.id didn't make it through the changes and is still shard_id

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, was actually a generation error. Fixed.

Bring it in line with Metricbeat and ECS to allow correlation.
@jsoriano
Copy link
Member

Failing test is not related, merging this.

@jsoriano jsoriano merged commit 48ca723 into elastic:master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants