Replace index patterns in TSVB visualizations #7929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
bug
in progress
houndci-bot
reviewed
Aug 9, 2018
libbeat/dashboards/modify_json.go
Outdated
| return string(d) | ||
| } | ||
|
|
||
| func ReplaceIndexInDashboardObject(index string, content common.MapStr) common.MapStr { |
There was a problem hiding this comment.
exported function ReplaceIndexInDashboardObject should have comment or be unexported
libbeat/dashboards/modify_json.go
Outdated
| return visStateJSON | ||
| } | ||
|
|
||
| index_pattern, ok := params["index_pattern"].(string) |
There was a problem hiding this comment.
don't use underscores in Go names; var index_pattern should be indexPattern
jsoriano
commented
Aug 9, 2018
| @@ -42,24 +42,29 @@ type JSONFormat struct { | |||
| } | |||
|
|
|||
| func ReplaceIndexInIndexPattern(index string, content common.MapStr) common.MapStr { | |||
There was a problem hiding this comment.
Changes here are not directly related, I have just reorganized the code to have less nesting levels in these functions. Result should be the same.
jsoriano
force-pushed
the
visstate-index-pattern-replace
branch
from
8601e6d
to
561cba2
Compare
When customizing the index pattern with `setup.dashboards.index`, references to index patterns need to be replaced in imported dashboards. It was not being done with objects that contain the index pattern in the `visState` object, as is the case of TSVB visualizations.
jsoriano
force-pushed
the
visstate-index-pattern-replace
branch
from
561cba2
to
b0fc21a
Compare
ruflin
approved these changes
Aug 9, 2018
| @@ -42,24 +42,29 @@ type JSONFormat struct { | |||
| } | |||
|
|
|||
| func ReplaceIndexInIndexPattern(index string, content common.MapStr) common.MapStr { | |||
| @@ -69,3 +69,45 @@ func TestReplaceStringInDashboard(t *testing.T) { | |||
| assert.Equal(t, test.expected, result) | |||
| } | |||
| } | |||
|
|
|||
| func TestReplaceIndexInDashboardObject(t *testing.T) { | |||
There was a problem hiding this comment.
Great, wanted to ask for tests :-)
jsoriano
added
the
needs_backport
|
@ruflin it was in progress, I was testing it, I think it is not working with |
|
No, sorry, false alarm, it is working 😃 |
jsoriano
added
v6.5.0
and removed
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Aug 9, 2018
When customizing the index pattern with `setup.dashboards.index`, references to index patterns need to be replaced in imported dashboards. It was not being done with objects that contain the index pattern in the `visState` object, as is the case of TSVB visualizations. (cherry picked from commit 7a8a476)
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Aug 9, 2018
When customizing the index pattern with `setup.dashboards.index`, references to index patterns need to be replaced in imported dashboards. It was not being done with objects that contain the index pattern in the `visState` object, as is the case of TSVB visualizations. (cherry picked from commit 7a8a476)
|
Sorry about the |
ruflin
pushed a commit
that referenced
this pull request
Aug 10, 2018
When customizing the index pattern with `setup.dashboards.index`, references to index patterns need to be replaced in imported dashboards. It was not being done with objects that contain the index pattern in the `visState` object, as is the case of TSVB visualizations. (cherry picked from commit 7a8a476)
ruflin
pushed a commit
that referenced
this pull request
Aug 10, 2018
When customizing the index pattern with `setup.dashboards.index`, references to index patterns need to be replaced in imported dashboards. It was not being done with objects that contain the index pattern in the `visState` object, as is the case of TSVB visualizations. (cherry picked from commit 7a8a476)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…#7932) When customizing the index pattern with `setup.dashboards.index`, references to index patterns need to be replaced in imported dashboards. It was not being done with objects that contain the index pattern in the `visState` object, as is the case of TSVB visualizations. (cherry picked from commit f27fd7a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When customizing the index pattern with
setup.dashboards.index,references to index patterns need to be replaced in imported dashboards.
It was not being done with objects that contain the index pattern in
the
visStateobject, as is the case of TSVB visualizations.