Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example of autodiscover to deployment manifests #8029

Merged
merged 2 commits into from Aug 21, 2018

Conversation

exekias
Copy link
Contributor

@exekias exekias commented Aug 20, 2018

Autodiscover is not enabled by default (yet) in our example manifests.
This change includes examples on how to enable it for Filebeat and
Metricbeat.

This should ease the task for users who are willing to use autodiscover.

I also updated default settings to adapt manifests to latest changes in 6.4 (automatic enriching of events from Kubernetes module)

@exekias exekias added enhancement docs needs_backport PR is waiting to be backported to other branches. containers Related to containers use case v6.4.0 labels Aug 20, 2018
@exekias exekias requested a review from jsoriano August 20, 2018 23:23
Autodiscover is not enabled by default (yet) in our example manifests.
This change includes examples on how to enable it for Filebeat and
Metricbeat.

This should ease the task for users who are willing to use autodiscover.
#metricbeat.autodiscover:
# providers:
# - type: kubernetes
# host: ${HOSTNAME}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is $HOSTNAME always set? and is it always set to a hostname in the list of nodes? (e.g. I think nodes can be registered with their IPs)

Alternatively we can add the NODE_NAME environment variable.

        - name: NODE_NAME
          valueFrom:
            fieldRef:
              fieldPath: spec.nodeName

@exekias
Copy link
Contributor Author

exekias commented Aug 21, 2018

done!

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this 🙂

@jsoriano jsoriano merged commit 37b1e63 into elastic:master Aug 21, 2018
exekias added a commit to exekias/beats that referenced this pull request Aug 21, 2018
Autodiscover is not enabled by default (yet) in our example manifests.
This change includes examples on how to enable it for Filebeat and
Metricbeat.

This should ease the task for users who are willing to use autodiscover.

(cherry picked from commit 37b1e63)
@exekias exekias added v6.4.0 and removed needs_backport PR is waiting to be backported to other branches. labels Aug 21, 2018
jsoriano pushed a commit that referenced this pull request Aug 23, 2018
Autodiscover is not enabled by default (yet) in our example manifests.
This change includes examples on how to enable it for Filebeat and
Metricbeat.

This should ease the task for users who are willing to use autodiscover.

(cherry picked from commit 37b1e63)
exekias added a commit to exekias/beats that referenced this pull request Oct 2, 2018
Autodiscover is not enabled by default (yet) in our example manifests.
This change includes examples on how to enable it for Filebeat and
Metricbeat.

This should ease the task for users who are willing to use autodiscover.

(cherry picked from commit 37b1e63)
@exekias exekias added the v6.5.0 label Oct 2, 2018
exekias added a commit that referenced this pull request Oct 4, 2018
Autodiscover is not enabled by default (yet) in our example manifests.
This change includes examples on how to enable it for Filebeat and
Metricbeat.

This should ease the task for users who are willing to use autodiscover.

(cherry picked from commit 37b1e63)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…elastic#8037)

Autodiscover is not enabled by default (yet) in our example manifests.
This change includes examples on how to enable it for Filebeat and
Metricbeat.

This should ease the task for users who are willing to use autodiscover.

(cherry picked from commit 71c3ffd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants