Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistency in Elastic stack metricsets' code #8308

Merged
merged 30 commits into from Oct 25, 2018
Merged

Consistency in Elastic stack metricsets' code #8308

merged 30 commits into from Oct 25, 2018

Commits on Oct 23, 2018

  1. Consistent error handling in elasticsearch/cluster_stats metricset

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    654c691 View commit details
    Browse the repository at this point in the history

  2. Consistent error handling in elasticsearch/index_recovery metricset

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    b81e68c View commit details
    Browse the repository at this point in the history

  3. Remove punctuation from error messages

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    d31db81 View commit details
    Browse the repository at this point in the history

  4. Inline variable

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    da50d8b View commit details
    Browse the repository at this point in the history

  5. Reordering imports

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    a22bc35 View commit details
    Browse the repository at this point in the history

  6. Adding periods to the ends of godoc comments

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    4ab37c7 View commit details
    Browse the repository at this point in the history

  7. More consistency cleanup

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    6818949 View commit details
    Browse the repository at this point in the history

  8. More consistency fixes

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    c580f27 View commit details
    Browse the repository at this point in the history

  9. More consistency fixes

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    9594363 View commit details
    Browse the repository at this point in the history

  10. Fixing API path

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    3deed0b View commit details
    Browse the repository at this point in the history

  11. Consistent code in elasticsearch/pending_tasks metricset

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    45cab6a View commit details
    Browse the repository at this point in the history

  12. More code consistency

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    451fa56 View commit details
    Browse the repository at this point in the history

  13. Consistent code in elasticsearch/shard metricset

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    c40655f View commit details
    Browse the repository at this point in the history

  14. Consistent code in elasticsearch/ccr metricset

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    e32d2b1 View commit details
    Browse the repository at this point in the history

  15. Making code in kibana module metricsets consistent

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    1e5c38d View commit details
    Browse the repository at this point in the history

  16. Making fully-qualified metricset name consistent

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    2baf502 View commit details
    Browse the repository at this point in the history

  17. Use elasticsearch.ModuleName constant instead of string literal

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    a847e4e View commit details
    Browse the repository at this point in the history

  18. Making logstash/node metricset code consistent

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    8701cb9 View commit details
    Browse the repository at this point in the history

  19. Making the logstash/node_stats metricset code consistent

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    c3631b4 View commit details
    Browse the repository at this point in the history

  20. Refactoring common reporting and error pattern into helper function

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    40f3406 View commit details
    Browse the repository at this point in the history

  21. Updating unit tests

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    acf6930 View commit details
    Browse the repository at this point in the history

  22. Changes from running make fmt

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    db6a2d2 View commit details
    Browse the repository at this point in the history

  23. Re-running make fmt after downgrading golang to 10.3

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    12a4015 View commit details
    Browse the repository at this point in the history

  24. Fixes due to make update

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    0befa82 View commit details
    Browse the repository at this point in the history

  25. Updating LS module integration tests

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    a864b21 View commit details
    Browse the repository at this point in the history

  26. Update kibana/status integration test

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    6b6bb3c View commit details
    Browse the repository at this point in the history

  27. Report error with event (for non x-pack path)

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    5291885 View commit details
    Browse the repository at this point in the history

  28. Attaching errors to events

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    35447b1 View commit details
    Browse the repository at this point in the history

  29. Fixing imports in integration tests

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    3be2ae3 View commit details
    Browse the repository at this point in the history

  30. Fixing error

    @ycombinator
    ycombinator committed Oct 23, 2018
    Copy the full SHA
    ab3a9ce View commit details
    Browse the repository at this point in the history