Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #8487 to 6.4: Avoid mapping issues in kubernetes module #8507

Merged
merged 3 commits into from Oct 4, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.asciidoc
Expand Up @@ -37,6 +37,8 @@ https://github.com/elastic/beats/compare/v6.4.1...6.4[Check the HEAD diff]

*Metricbeat*

- Avoid mapping issues in kubernetes module. {pull}8487[8487]

*Packetbeat*

*Winlogbeat*
Expand Down
21 changes: 21 additions & 0 deletions metricbeat/docs/fields.asciidoc
Expand Up @@ -8053,6 +8053,27 @@ type: long
Count field records the number of times the particular event has occurred


--


*`kubernetes.event.timestamp.first_occurrence`*::
+
--
type: date

Timestamp of first occurrence of event


--

*`kubernetes.event.timestamp.last_occurrence`*::
+
--
type: date

Timestamp of last occurrence of event


--

*`kubernetes.event.message`*::
Expand Down
7 changes: 5 additions & 2 deletions metricbeat/module/kubernetes/container/data.go
Expand Up @@ -52,8 +52,7 @@ func eventMapping(content []byte, perfMetrics *util.PerfMetricsCache) ([]common.
},
},

"name": container.Name,
"start_time": container.StartTime,
"name": container.Name,

"cpu": common.MapStr{
"usage": common.MapStr{
Expand Down Expand Up @@ -114,6 +113,10 @@ func eventMapping(content []byte, perfMetrics *util.PerfMetricsCache) ([]common.
},
}

if container.StartTime != "" {
containerEvent.Put("start_time", container.StartTime)
}

if nodeCores > 0 {
containerEvent.Put("cpu.usage.node.pct", float64(container.CPU.UsageNanoCores)/1e9/nodeCores)
}
Expand Down
21 changes: 10 additions & 11 deletions metricbeat/module/kubernetes/event/_meta/fields.yml
Expand Up @@ -9,18 +9,17 @@
type: long
description: >
Count field records the number of times the particular event has occurred
- name: timestamp
type: group
fields:
- name: timestamp
type: group
fields:
- name: first_occurrence
type: date
description: >
Timestamp of first occurrence of event
- name: last_occurrence
type: date
description: >
Timestamp of last occurrence of event
- name: first_occurrence
type: date
description: >
Timestamp of first occurrence of event
- name: last_occurrence
type: date
description: >
Timestamp of last occurrence of event
- name: message
type: keyword
description: >
Expand Down
2 changes: 1 addition & 1 deletion metricbeat/module/kubernetes/fields.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions metricbeat/module/kubernetes/node/data.go
Expand Up @@ -34,8 +34,7 @@ func eventMapping(content []byte) (common.MapStr, error) {

node := summary.Node
nodeEvent := common.MapStr{
"name": node.NodeName,
"start_time": node.StartTime,
"name": node.NodeName,

"cpu": common.MapStr{
"usage": common.MapStr{
Expand Down Expand Up @@ -105,5 +104,10 @@ func eventMapping(content []byte) (common.MapStr, error) {
},
},
}

if node.StartTime != "" {
nodeEvent.Put("start_time", node.StartTime)
}

return nodeEvent, nil
}
7 changes: 5 additions & 2 deletions metricbeat/module/kubernetes/pod/data.go
Expand Up @@ -58,8 +58,7 @@ func eventMapping(content []byte, perfMetrics *util.PerfMetricsCache) ([]common.
"name": node.NodeName,
},
},
"name": pod.PodRef.Name,
"start_time": pod.StartTime,
"name": pod.PodRef.Name,

"cpu": common.MapStr{
"usage": common.MapStr{
Expand All @@ -85,6 +84,10 @@ func eventMapping(content []byte, perfMetrics *util.PerfMetricsCache) ([]common.
},
}

if pod.StartTime != "" {
podEvent.Put("start_time", pod.StartTime)
}

if coresLimit > nodeCores {
coresLimit = nodeCores
}
Expand Down
8 changes: 6 additions & 2 deletions metricbeat/module/kubernetes/system/data.go
Expand Up @@ -44,8 +44,7 @@ func eventMapping(content []byte) ([]common.MapStr, error) {
"name": node.NodeName,
},
},
"container": syscontainer.Name,
"start_time": syscontainer.StartTime,
"container": syscontainer.Name,
"cpu": common.MapStr{
"usage": common.MapStr{
"nanocores": syscontainer.CPU.UsageNanoCores,
Expand All @@ -68,6 +67,11 @@ func eventMapping(content []byte) ([]common.MapStr, error) {
"majorpagefaults": syscontainer.Memory.MajorPageFaults,
},
}

if syscontainer.StartTime != "" {
containerEvent.Put("start_time", syscontainer.StartTime)
}

events = append(events, containerEvent)
}

Expand Down