Cherry-pick #8533 to 6.x: Fix source_node logic in elasticsearch/shards xpack code #8547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add source_node to elasticsearch/shard metricset xpack code * Only add source_node if shard has been allocated to node (cherry picked from commit 3fedc8d)
ruflin
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8533 to 6.x branch. Original message:
This PR fixes the data in the
source_nodeobject present inshardstype documents in.monitoring-es-6-*. It also saves an extra ES API call by requesting a bit of additional information (nodes) from theGET _cluster/stateES API call already being made by the metricset.Note that the
source_nodeobject constructed by thegetSourceNodefunction is partial. It only contains two fields,uuidandname, because these are the only two fields actually used by the Monitoring UI.