Cherry-pick #8308 to 6.x: Consistency in Elastic stack metricsets' code #8755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins, test this |
ycombinator
force-pushed
the
backport_8308_6.x
branch
from
4963aaf
to
06943c8
Compare
ycombinator
force-pushed
the
backport_8308_6.x
branch
2 times, most recently
from
872b7cb
to
6159c81
Compare
|
jenkins, test this |
* Consistent error handling in elasticsearch/cluster_stats metricset * Consistent error handling in elasticsearch/index_recovery metricset * Remove punctuation from error messages * Inline variable * Reordering imports * Adding periods to the ends of godoc comments * More consistency cleanup * More consistency fixes * More consistency fixes * Fixing API path * Consistent code in elasticsearch/pending_tasks metricset * More code consistency * Consistent code in elasticsearch/shard metricset * Consistent code in elasticsearch/ccr metricset * Making code in kibana module metricsets consistent * Making fully-qualified metricset name consistent * Use elasticsearch.ModuleName constant instead of string literal * Making logstash/node metricset code consistent * Making the logstash/node_stats metricset code consistent * Refactoring common reporting and error pattern into helper function * Updating unit tests * Changes from running make fmt * Re-running make fmt after downgrading golang to 10.3 * Fixes due to make update * Updating LS module integration tests * Update kibana/status integration test * Report error with event (for non x-pack path) * Attaching errors to events * Fixing imports in integration tests * Fixing error (cherry picked from commit 3b2399d)
ycombinator
force-pushed
the
backport_8308_6.x
branch
from
6159c81
to
8958e89
Compare
ruflin
approved these changes
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8308 to 6.x branch. Original message:
This PR makes error messages, reporting, and logging consistent across all metricsets for Elastic stack products, including the xpack monitoring code paths:
elasticsearch/ccrelasticsearch/cluster_statselasticsearch/indexelasticsearch/index_recoveryelasticsearch/index_summaryelasticsearch/ml_jobelasticsearch/nodeelasticsearch/node_statselasticsearch/pending_taskselasticsearch/shardkibana/statuskibana/statslogstash/nodelogstash/node_stats