Cherry-pick #9056 to 6.x: Use _doc if ES major version is 7 #9390
Conversation
Update the Elasticsearch output and template generator to set the type to _doc if Elasticsearch major version is 7. Use common.Version throughout - Use common version instead of strings + parsing over and over again. - Having the parsed version available earlier, we can now configure the default document type based on version ranges. - Use `_doc` if version is >= 7.0. Introduce unit tests for version aware bulk encoding. (cherry picked from commit 41f87a4)
|
The failures are presistent so I wonder how they are related to this change. Does the template need adjustments or the tests at least? |
|
@urso What should be the upgrade behaviour here? Someone using MB 6.6 with ES 6.7 and then ES is upgraded, will still have the old template. As soon as he goes to the next version of MB, the new template will be loaded. Is that ok? |
|
It's a system test that fails. Unfortunately all system tests make assumptions about the ES version being used and how template format should look like. This will hunt us a while. |
Oh good point... this might be a problem. We have to update/overwrite the template when we detect ES is updated. Otherwise ES will reject indexing due to us having two types In the future (not yet supported by ES) we will remove the Thinking about it, we should wait with backporting the change until 6.6 has it's own branch AND we do not set |
Cherry-pick of PR #9056 to 6.x branch. Original message:
Update the Elasticsearch output and template generator to set the type
to _doc if Elasticsearch major version is 7.