Rename process.exe to process.executable for ECS #9949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
commented
Jan 8, 2019
There was a problem hiding this comment.
@andrewkroh It seems there is also in auditbeat process.exe?
Yes, the Auditbeat auditd module produces this field. beats/auditbeat/module/auditd/audit_linux.go Line 571 in ae290b4 |
|
I added to this PR the change in the auditd module in auditbeat. |
ruflin
added
review
and removed
in progress
|
@andrewkroh Could you take another look as it now also affects auditbeat? |
webmat
reviewed
Jan 10, 2019
andrewkroh
approved these changes
Jan 11, 2019
| @@ -568,7 +568,7 @@ func addProcess(p aucoalesce.Process, m common.MapStr) { | |||
| process["name"] = p.Name | |||
| } | |||
| if p.Exe != "" { | |||
| process["exe"] = p.Exe | |||
| process["executable"] = p.Exe | |||
There was a problem hiding this comment.
This package has a data.json and I think an execve.json that should be updated. You can run go test . -data on Linux to update them.
There was a problem hiding this comment.
Done, it unfortunately also removed some entries which are probably available in other envs.
ruflin
force-pushed
the
ecs-process-metadata
branch
from
2d655e9
to
941a91f
Compare
urso
approved these changes
Jan 11, 2019
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
This also updates the auditbeat auditd module to use process.executable instead of process.exe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also updates the auditbeat auditd module to use process.executable instead of process.exe.