Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the serviceName feature #4576

Closed
pebrc opened this issue Jun 16, 2021 · 1 comment
Closed

Document the serviceName feature #4576

pebrc opened this issue Jun 16, 2021 · 1 comment
Labels
>docs Documentation

Comments

@pebrc
Copy link
Collaborator

pebrc commented Jun 16, 2021

The service name feature introduced in #4404 is currently only documented in our CRD API docs. We should mention it in the product documentation. We should also call out that if users chose to customise the service and chose to override the default port declaration they need to use either "https" for TLS secured connections or "http" for unencrypted connections.

@pebrc pebrc added the >docs Documentation label Jun 16, 2021
@pebrc
Copy link
Collaborator Author

pebrc commented Jul 22, 2021

This is actually already documented in the advanced section under "traffic splitting" (and mentioned in a few other places) so I am closing this issue.

@pebrc pebrc closed this as completed Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs Documentation
Projects
None yet
Development

No branches or pull requests

1 participant