Allow users to spec a serviceName in associations #4404
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3732
1000 lines of YAML say more than 100 words:
Add a new
serviceName
attribute to all associations (even though it makes only sense for Elasticsearch but the tradeoff here is additional complexity in the code). Query for the referenced service, extract the configured port which matches the currently configured protocol of the managed resource (e.g. Elasticsearch running with HTTPS) and use it to construct a service URL which will be configured in the associated resource.https
orhttp
(which is compatible with Istio's port naming convention btw)