Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different admissionReviewVersions between Maps and Agent webhooks #6152

Closed
thbkrkr opened this issue Nov 8, 2022 · 0 comments · Fixed by #6489
Closed

Different admissionReviewVersions between Maps and Agent webhooks #6152

thbkrkr opened this issue Nov 8, 2022 · 0 comments · Fixed by #6489
Assignees
@pebrc
Labels
>bug Something isn't working

Comments

@thbkrkr
Copy link
Contributor

thbkrkr commented Nov 8, 2022 •
edited
Loading

I spotted a small difference in admissionReviewVersions in the following webhooks manifests:

  • generated config/webhook/manifests.yaml [v1;v1beta1] except for maps [v1alpha1]
  • deploy/eck-operator/templates/webhook.yaml [v1beta1]

It is not a real issue because only the second file is used to generate the operator manifest for the all-in-one via manifest-gen and the Helm Chart.

Shouldn't we set [v1;v1beta1] everywhere?
@thbkrkr thbkrkr added the >bug Something isn't working label Nov 8, 2022
@pebrc pebrc self-assigned this Mar 6, 2023
@pebrc pebrc mentioned this issue Mar 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pebrc pebrc

Labels
>bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing maps webhook, fix inconsistencies pebrc/cloud-on-k8s
2 participants
@thbkrkr @pebrc