Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose all fields below spec in eck-resources Helm charts #6451

Closed
thbkrkr opened this issue Feb 23, 2023 · 3 comments
Closed

Expose all fields below spec in eck-resources Helm charts #6451

thbkrkr opened this issue Feb 23, 2023 · 3 comments
Assignees
Labels
>enhancement Enhancement of existing functionality

Comments

@thbkrkr
Copy link
Contributor

thbkrkr commented Feb 23, 2023

Follow-up of #6249, there are 4 fields that are not exposed in the eck-elasticsearch Helm chart:

spec:
  image:
  podDisruptionBudget:
  serviceAccountName:
  revisionHistoryLimit:

Let's make a pass on other elastic resources to verify that their Helm chart is ISO with the CRD....

@thbkrkr thbkrkr added the >enhancement Enhancement of existing functionality label Feb 23, 2023
@alanspencer24
Copy link

We also need this issue to be worked because we are working in an air-gapped environment. Per your documentation below

https://www.elastic.co/guide/en/cloud-on-k8s/current/k8s-air-gapped.html

we can't specify the image in your CRD until the image value is exposed in these charts

@thbkrkr
Copy link
Contributor Author

thbkrkr commented Mar 7, 2023

Only Helm eck-elasticsearch chart has unexposed fields. In the other eck-resources Helm charts, the whole spec is exposed.

@thbkrkr
Copy link
Contributor Author

thbkrkr commented Mar 7, 2023

Closed by #6492.

@thbkrkr thbkrkr closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement Enhancement of existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants