Add flag for debug logs #1166
Merged
Add flag for debug logs #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thbkrkr
reviewed
Jul 1, 2019
operators/cmd/main.go
Outdated
|
|
||
| cobra.OnInitialize(func() { | ||
| logf.SetLogger(logf.ZapLogger(dev.Enabled)) | ||
| level, _ := rootCmd.Flags().GetString(logLevelFlag) | ||
| logLevel := false |
There was a problem hiding this comment.
Nit: I would tend to name the logLevel boolean variable enableDebugLevel instead of logLevel to better reflect what it does and then name level in logLevel.
There was a problem hiding this comment.
I thought about that but wasn't sure if we might want to have a separate debug mode (maybe enabling profiling if we're not already?). That's not a very persuasive argument though so I'm good with changing it
thbkrkr
reviewed
Jul 1, 2019
pebrc
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a distinct log level flag to enable debug logs (rather than as part of the development flag), as part of #305
I wasn't sure if we wanted a flag or env var, so I followed how it was previously set up. Definitely open to changing it. Modifying env vars (or a env vars via a config map) feels slightly preferable but I don't feel strongly either way.