Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not reconcile APM Server if association is not fully configured #2224

Merged
merged 6 commits into from
Dec 10, 2019
Merged

Do not reconcile APM Server if association is not fully configured #2224

merged 6 commits into from
Dec 10, 2019

Conversation

barkbay
Copy link
Contributor

@barkbay barkbay commented Dec 6, 2019

The APM Server deployment is created/updated even if the association is not fully configured, it generates some Error/CrashLoopBackoff:

NAME                                             READY   STATUS             RESTARTS   AGE   IP           NODE                                          NOMINATED NODE   READINESS GATES
pod/apm-apm-sample-apm-server-5c587f4677-929hk   0/1     Running            0          11s   10.32.0.22   gke-michael-dev3-default-pool-0719275e-cgd6   <none>           <none>
pod/apm-apm-sample-apm-server-6bc976799d-d6g6r   0/1     CrashLoopBackOff   1          12s   10.32.2.22   gke-michael-dev3-default-pool-d47071e7-jsql   <none>           <none>

2019-12-06T11:03:09.853Z        INFO    instance/beat.go:325    No outputs are defined. Please define one under the output section.
2019-12-06T11:03:09.853Z        INFO    instance/beat.go:385    apm-server stopped.
2019-12-06T11:03:09.853Z        ERROR   instance/beat.go:878    Exiting: No outputs are defined. Please define one under the output section.
Exiting: No outputs are defined. Please define one under the output section.

This PR prevents the creation/update of the APM Server deployment while the association is not yet fully configured.

@barkbay barkbay added >enhancement Enhancement of existing functionality v1.0.0 labels Dec 6, 2019
pebrc
pebrc previously requested changes Dec 6, 2019
View reviewed changes
pkg/controller/apmserver/apmserver_controller.go Outdated Show resolved Hide resolved
thbkrkr
thbkrkr reviewed Dec 6, 2019
View reviewed changes
pkg/controller/common/association/association.go Outdated Show resolved Hide resolved
pkg/controller/kibana/driver.go Outdated Show resolved Hide resolved
@pebrc pebrc dismissed their stale review December 6, 2019 14:11

It did not have merit

thbkrkr
thbkrkr approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@thbkrkr thbkrkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barkbay barkbay merged commit 90bee95 into elastic:master Dec 10, 2019
mjmbischoff pushed a commit to mjmbischoff/cloud-on-k8s that referenced this pull request Jan 13, 2020
@barkbay @mjmbischoff
Do not reconcile APM Server if association is not fully configured (e…
39b7ab7 
…lastic#2224)

* Do not reconcile APM Server if association is not ready
@pebrc pebrc mentioned this pull request Oct 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pebrc pebrc pebrc left review comments

@thbkrkr thbkrkr thbkrkr approved these changes

Assignees
No one assigned
Labels
>enhancement Enhancement of existing functionality v1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@barkbay @thbkrkr @pebrc