Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch operator base image to Distroless #3161

Merged
merged 3 commits into from
Jun 3, 2020

Conversation

anyasabo
Copy link
Contributor

We had previously decided on centos to standardize with the rest of elastic products and to set us up for OpenShift certification. Neither of those apply at this time, but we do semi-frequently field issues about vulnerabilities in our image that show up on scans. These largely (entirely?) do not affect us, but there is still a maintenance burden in reviewing the results and responding. There is also a build time burden of needing to update all of the packages on every image build. Since we do not use any of the packages this change would make both our lives and our security team's lives easier.

Note: if we merge this we will also want to update the image dependencies documentation. It's kind of a pain though because it doesn't run on OSX so I did not do it yet since I wasn't sure if we would want to merge this.

@anyasabo anyasabo added >enhancement Enhancement of existing functionality v1.2.0 labels May 28, 2020
Copy link
Contributor

@charith-elastic charith-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 You beat me to this PR. With the Kubernetes project switching to distroless itself, I don't see a reason why we shouldn't do this. We can always publish a second variant of the image for those environments that do require a full OS base.

Tern output is empty for this image so I think we can just get rid of the container image dependencies section from the docs.

@pcsanwald
Copy link

It's hard to argue with this change given your points on k8s itself switching, but, if we wanted to err on the side of caution, it could be worth a broader email just saying "hey we intend to do this, please raise any concerns" just to give field/infra teams a heads up, as this will effect scanning (in a good way hopefully). That could be unnecessary, though, would defer to y'alls judgement.

@anyasabo anyasabo merged commit f9faf27 into elastic:master Jun 3, 2020
@anyasabo anyasabo deleted the distroless branch June 3, 2020 13:49
@charith-elastic charith-elastic added the release-highlight Candidate for the ECK release highlight summary label Jun 12, 2020
@charith-elastic charith-elastic changed the title Switch to distroless Switch operator base image to Distroless Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement Enhancement of existing functionality release-highlight Candidate for the ECK release highlight summary v1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants