Only provision Enterprise licenses as of 7.8.1 #3273
Conversation
This is to avoid breakage in older clients that call the deprecated '_xpack' API to query the license level which is not backwards compatible.
|
I realized we should update or remove the comment here
|
| @@ -111,7 +111,7 @@ func xpackConfig(ver version.Version, httpCfg commonv1.HTTPConfig) *CanonicalCon | |||
| cfg[esv1.XPackSecurityAuthcRealmsNativeNative1Order] = -99 | |||
| } | |||
|
|
|||
| if ver.IsSameOrAfter(version.MustParse("7.6.0")) { | |||
| if ver.IsSameOrAfter(version.MustParse("7.8.1")) { | |||
| cfg[esv1.XPackLicenseUploadTypes] = []string{ | |||
There was a problem hiding this comment.
I'm wondering what will happen if people do a version upgrade from 7.7.0 (platinum license) to 7.8.1 (requires an Enterprise license). Can they just continue with the existing platinum license, and only a call to refresh the license would be impacted?
There was a problem hiding this comment.
This could potentially lead to unpleasant errors in the logs. If the license was still valid everything would be fine. But once it expires or gets close to expire the operator would still try to apply a platinum license to the 7.8.1 cluster which would fail because of the restriction.
I think we should at least not try to apply a platinum license.
This reverts commit 372ca33.
|
Apologies for the back and forth but after sleeping over this I think the last commit which I just reverted might cause more problems than it solves. Leaving the matching logic unchanged gives us a bit more maneuvering space in case things go wrong at the cost of an unhelpful error message. I think we should think about a more comprehensive approach that would give us seamless bwc compatibility with older licenses but that should be a separate PR. |
This is to avoid breakage in older clients that call the deprecated
'_xpack' API to query the license level which is not backwards compatible.
This is optimistically assuming that the fix is landing in 7.8.1
Fixes #3272