Use new node_names query param for voting exclusions as of 7.8.0 #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new query parameter tolerates non-existing nodes and covers therefore the case where we try to remove a master node that has never successfully joined the cluster. This prevents and orchestration dead lock where the operator was previously unable to make progress due to an API error returned by Elasticsearch.
sebgl
approved these changes
Nov 18, 2020
| if c.version.IsSameOrAfter(version.From(7, 8, 0)) { | ||
| path = fmt.Sprintf("/_cluster/voting_config_exclusions?node_names=%s", strings.Join(nodeNames, ",")) | ||
| } else { | ||
| path = fmt.Sprintf("/_cluster/voting_config_exclusions/%s", strings.Join(nodeNames, ",")) |
There was a problem hiding this comment.
If c.version is empty (client constructed from client.NewElasticsearchClient()), we end up in this else path, which is fine.
Maybe worth explicitly pointing out in a comment though?
There was a problem hiding this comment.
Not sure I follow your argument wrt to client.NewElasticsearchClient() but I added a comment.
There was a problem hiding this comment.
I meant client which do not have a version set, which I think is the case when built from client.NewElasticsearchClient().
I'm 👍 with the comment.
sebgl
approved these changes
Nov 18, 2020
| if c.version.IsSameOrAfter(version.From(7, 8, 0)) { | ||
| path = fmt.Sprintf("/_cluster/voting_config_exclusions?node_names=%s", strings.Join(nodeNames, ",")) | ||
| } else { | ||
| path = fmt.Sprintf("/_cluster/voting_config_exclusions/%s", strings.Join(nodeNames, ",")) |
There was a problem hiding this comment.
I meant client which do not have a version set, which I think is the case when built from client.NewElasticsearchClient().
I'm 👍 with the comment.
pebrc
added a commit
to pebrc/cloud-on-k8s
that referenced
this pull request
Nov 19, 2020
…stic#3950) The new query parameter tolerates non-existing node names and covers therefore the case where we try to remove a master node that has never successfully joined the cluster. This prevents an orchestration deadlock where the operator was previously unable to make progress due to an API error returned by Elasticsearch.
pebrc
added a commit
that referenced
this pull request
Nov 24, 2020
…) (#3954) The new query parameter tolerates non-existing node names and covers therefore the case where we try to remove a master node that has never successfully joined the cluster. This prevents an orchestration deadlock where the operator was previously unable to make progress due to an API error returned by Elasticsearch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new query parameter tolerates non-existing nodes and covers therefore the case where we try to remove a master node that has never successfully joined the cluster. This prevents an orchestration dead lock where the operator was previously unable to make progress due to an API error returned by Elasticsearch for nodes that were not part of the cluster.
Fixes #2951