Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticsearch: always set discovery.seed_hosts to empty array #5950

Merged
merged 4 commits into from
Aug 16, 2022

Conversation

pebrc
Copy link
Collaborator

@pebrc pebrc commented Aug 12, 2022

Fixes #5834

@pebrc pebrc added >enhancement Enhancement of existing functionality v2.5.0 labels Aug 12, 2022
@thbkrkr thbkrkr changed the title Elasticsearch: alwasy set discovery.seed_hosts to empty array Elasticsearch: always set discovery.seed_hosts to empty array Aug 12, 2022
@thbkrkr thbkrkr self-assigned this Aug 12, 2022
Copy link
Contributor

@thbkrkr thbkrkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the setting to https://www.elastic.co/guide/en/cloud-on-k8s/2.3/k8s-reserved-settings.html? By the way, discovery.seed_providers is missing.

@thbkrkr
Copy link
Contributor

thbkrkr commented Aug 12, 2022

run/e2e-tests tags=es

Build Status

@pebrc
Copy link
Collaborator Author

pebrc commented Aug 12, 2022

discovery.seed_hosts did not exist in 6.8 I need to add some version specific code.

Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
Copy link
Contributor

@thbkrkr thbkrkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pebrc
Copy link
Collaborator Author

pebrc commented Aug 16, 2022

Jenkins test this please

@pebrc pebrc merged commit 64d677d into elastic:main Aug 16, 2022
fantapsody pushed a commit to fantapsody/cloud-on-k8s that referenced this pull request Feb 7, 2023
…c#5950)

This is to avoid confusing error messages about nodes not being able to connect to localhost for discovery.

Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement Enhancement of existing functionality v2.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set discovery.seed_hosts: [] even when using file based seed hosts provider
2 participants