Add details about rolling restart behavior #7372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thbkrkr
approved these changes
Dec 8, 2023
|
@thbkrkr Thanks! I checkout from the wrong branch (2.7), not sure how I can fix this from a commit perspective. Trying to rebase on |
|
You can open a PR or force push a new branch, as you want. # if this repo is the remote 'upstream'
g fetch upstream # optional to update your local main
g co main
g rebase upstream/main # optional to update your local main
g co -b jeanfabrice-docfix-rollingrestart-2
g lg jeanfabrice-docfix-rollingrestart | head -2
g cherry-pick 6fa4461d3 && g cherry-pick bff575791
# if your fork is the remote 'origin'
g push -f origin jeanfabrice-docfix-rollingrestart-2:jeanfabrice-docfix-rollingrestart |
jeanfabrice
force-pushed
the
jeanfabrice-docfix-rollingrestart
branch
from
bff5757
to
d26f3bb
Compare
|
Destination branch has been changed for |
pebrc
reviewed
Dec 11, 2023
pebrc
approved these changes
Dec 11, 2023
robbavey
pushed a commit
to robbavey/cloud-on-k8s
that referenced
this pull request
Dec 20, 2023
thbkrkr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it clear that stepping over a version that triggers a restart still triggers a restart