Change deployment-alias type to *string. #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deployment-alias field has the following behavior: - Not added in request -> Don't update field - Set to empty value -> Remove deployment alias - Set to non-empty value -> Set alias to that value So with the old spec, it wasn't possible to remove the alias after it was set, as due to `omitempty` an empty value is not added to the request. This is now possible.
dimuon
reviewed
May 22, 2024
dimuon
approved these changes
May 23, 2024
10 tasks
gigerdo
added a commit
to elastic/terraform-provider-ec
that referenced
this pull request
Jun 24, 2024
Fixes an error scenario when using the empty string for alias: - The expectation is to remove the alias - The empty string used to not be transferred to the backend, so no update to the alias was made - This lead to a terraform error as the resulting state was different from the config Now the behavior is: - Unconfigured -> alias is left untouched and not managed by terraform (When creating this will add a default alias) - Set to empty string -> alias is removed - Set to non-empty string -> alias is set to this value Related change in cloud-sdk-go: elastic/cloud-sdk-go#472
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deployment-alias field has the following behavior:
So with the old spec, it wasn't possible to remove the alias after it was set, as due to
omitemptyan empty value is not added to the request. This is now possible.Description
Related Issues
Motivation and Context
How Has This Been Tested?
Types of Changes
Readiness Checklist