Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Export from cf direct keys #2281

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

moukoublen
Copy link
Member

@moukoublen moukoublen commented Jun 20, 2024

Summary of your changes

The Export feature within the Output section allows you to create a named export that other CloudFormation stacks can import. It is not actually needed, and it seems to cause some internal failure when we deploy multiple stacks with output exports.

Screenshot/Data

Screenshot 2024-06-20 at 6 22 52 PM Screenshot 2024-06-20 at 6 30 46 PM

Related Issues

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Introducing a new rule?

@moukoublen moukoublen requested a review from a team as a code owner June 20, 2024 15:23
Copy link

mergify bot commented Jun 20, 2024

This pull request does not have a backport label. Could you fix it @moukoublen? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

Copy link

📊 Allure Report - 💚 No failures were reported.

Result Count
🟥 Failed 0
🟩 Passed 359
⬜ Skipped 33

@moukoublen moukoublen merged commit 9157e89 into elastic:main Jun 20, 2024
26 checks passed
@moukoublen moukoublen deleted the fix_cf_direct_key branch June 20, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants