fix validation regex containing pipe character breaks default markdown template table #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
pseudorandoom
force-pushed
the
fix-regex-with-pipe-character-breaks-default-validation-template-table
branch
from
32babbe
to
aafd727
Compare
thbkrkr
reviewed
Jul 23, 2024
| @@ -31,7 +31,7 @@ _Appears in:_ | |||
| {{ end -}} | |||
|
|
|||
| {{ range $type.Members -}} | |||
| | `{{ .Name }}` _{{ markdownRenderType .Type }}_ | {{ template "type_members" . }} | {{ markdownRenderDefault .Default }} | {{ range .Validation -}} {{ . }} <br />{{ end }} | | |||
| | `{{ .Name }}` _{{ markdownRenderType .Type }}_ | {{ template "type_members" . }} | {{ markdownRenderDefault .Default }} | {{ range .Validation -}} {{ markdownRenderFieldDoc . }} <br />{{ end }} | | |||
There was a problem hiding this comment.
So we reuse markdownRenderFieldDoc to render the custom validation marker. It's ok-ish but not very clean for me. Similar to #81 (comment), let's merge and refactor this later.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation pattern is not currently markdown escaped and can break markdown's table markup when it includes a
|character