Add tests for the Kibana link checking changes in #2085 #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tested against a version of this repo prior to when #2085 was merged, it fails with these errors: ``` rspec './integtest/spec/all_books_broken_link_detection_spec.rb[1:2:5:1]' # building all books when broken link detection is enabled when there is a link in kibana to the website outside the guide logs that all the links are ok rspec './integtest/spec/all_books_broken_link_detection_spec.rb[1:2:6:1]' # building all books when broken link detection is enabled when there is a broken Elasticsearch reference link in Kibana logs there are bad cross document links rspec './integtest/spec/all_books_broken_link_detection_spec.rb[1:2:6:2]' # building all books when broken link detection is enabled when there is a broken Elasticsearch reference link in Kibana logs the bad link ```
olksdr
approved these changes
Mar 17, 2021
|
looks good, but there might be more places where tests are broken? |
nik9000
approved these changes
Mar 17, 2021
Yep, rubocop seems unhappy. Looks like I need to finally get a decent Ruby development environment set up rather than relying on running everything in Docker, or remembering to do that stuff before pushing 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tested against a version of this repo prior to when #2085 was merged, it fails with these errors:
This confirms that the changes in #2085 fix this issue.