Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for the Kibana link checking changes in #2085 #2086

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Add tests for the Kibana link checking changes in #2085 #2086

merged 2 commits into from
Mar 17, 2021

Commits on Mar 17, 2021

  1. Add tests for the Kibana link checking changes in #2085 

    When tested against a version of this repo prior to when #2085 was merged, it fails with these errors:

```
rspec './integtest/spec/all_books_broken_link_detection_spec.rb[1:2:5:1]' # building all books when broken link detection is enabled when there is a link in kibana to the website outside the guide logs that all the links are ok
rspec './integtest/spec/all_books_broken_link_detection_spec.rb[1:2:6:1]' # building all books when broken link detection is enabled when there is a broken Elasticsearch reference link in Kibana logs there are bad cross document links
rspec './integtest/spec/all_books_broken_link_detection_spec.rb[1:2:6:2]' # building all books when broken link detection is enabled when there is a broken Elasticsearch reference link in Kibana logs the bad link
```
    @gtback
    gtback committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    fb41508 View commit details
    Browse the repository at this point in the history

  2. Make rubocop happy

    @gtback
    gtback committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    3c71f14 View commit details
    Browse the repository at this point in the history