Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve nodejs.eventloop.delay.avg description #485

Merged
merged 2 commits into from
Jun 13, 2019
Merged

Conversation

watson
Copy link

@watson watson commented Jun 11, 2019

No description provided.

@watson watson requested a review from axw June 11, 2019 11:35
@watson watson self-assigned this Jun 11, 2019
@watson
Copy link
Author

watson commented Jun 11, 2019

How do I update the generated/ecs/ecs_nested.yml file?

@ruflin
Copy link
Member

ruflin commented Jun 11, 2019

@watson run make or mage generate.

@ruflin
Copy link
Member

ruflin commented Jun 11, 2019

@watson The place to update the docs is in the fields.yml then it will also generate the document you updated.

@webmat
Copy link
Contributor

webmat commented Jun 11, 2019

Yes, everything under generated/ you shouldn't touch, and only re-generate with make. No mage ;-)

@webmat
Copy link
Contributor

webmat commented Jun 11, 2019

@watson Yeah any tweaks to the schema should start in /schemas. Everything is generated from these files.

@watson
Copy link
Author

watson commented Jun 11, 2019

Getting this error when running make - wrong version of Go?:

# runtime/cgo
_cgo_export.c:3:10: fatal error: 'stdlib.h' file not found
make: *** [template] Error 2

@webmat
Copy link
Contributor

webmat commented Jun 11, 2019

We're trying to stay in line with the Golang version used by Beats, so 1.12.4 or .5 should do the trick.

Make sure your checkout of Beats is recent enough. Just git pull master should do. Not a great way to manage this external dependency, I know.

Not familiar at all with this error. Do you have the XCode command line tools installed?

@watson
Copy link
Author

watson commented Jun 11, 2019

We're trying to stay in line with the Golang version used by Beats, so 1.12.4 or .5 should do the trick.

I have Go 1.11.5 currently. That's probably the main issue then. I'll try to see if I can remember how it was installed - haven't used it in ages 😅

Make sure your checkout of Beats is recent enough. Just git pull master should do. Not a great way to manage this external dependency, I know.

Does this repo require the beats repo to be cloned somewhere else on my computer? I don't have beats anywhere on my hard drive currently.

Do you have the XCode command line tools installed?

Yes

@webmat
Copy link
Contributor

webmat commented Jun 11, 2019

I'm trying to get rid of go in ECS, because I'm as familiar as you are with it LOL

You can likely upgrade Golang via homebrew.

Once you've upgraded Go, you can get the Beats code in the right place with go get github.com/elastic/beats or something to that effect. That'll put it in the right place for the imports to pick it up.

@watson
Copy link
Author

watson commented Jun 11, 2019

I upgraded Go to v1.12.5 and pull the latest version of beats, but now I think I probably have the wrong version of Python (v3.7.0). When running make I now get this error:

cd scripts \
          && GO111MODULE=on go run cmd/template/template.go \
                -version=1.1.0-dev \
                -schema=../schemas \
                > ../generated/legacy/template.json
build/ve/bin/python scripts/use-cases.py --stdout=true >> /dev/null
find code/go/ecs -name '*.go' -not -name 'doc.go' | xargs rm
cd scripts \
          && GO111MODULE=on go run cmd/gocodegen/gocodegen.go \
                -version=1.1.0-dev \
                -schema=../schemas \
                -out=../code/go/ecs
build/ve/bin/python scripts/generator.py
  File "scripts/generator.py", line 15
    print "Running generator. ECS version " + ecs_version
                                          ^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print("Running generator. ECS version " + ecs_version)?
make: *** [generator] Error 1

@webmat
Copy link
Contributor

webmat commented Jun 11, 2019

Yeah I have to migrate all this to Python 3 at some point, 🤦‍♂

So brew install python@2

@ruflin
Copy link
Member

ruflin commented Jun 12, 2019

Can we document these pitfalls somewhere to make sure before we fix it we can point other contributors to it?

@watson
Copy link
Author

watson commented Jun 12, 2019

I unfortunately don't have time to fix this PR right now. I've updated the PR to only change the file I was supposed to change, but the generated files have not been updated. If someone wants to take it on feel free 😃

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @watson!
I've regenerated the other bits and pushed to the branch.

@axw axw merged commit f1691c9 into ecs-metrics Jun 13, 2019
@axw axw deleted the nodejs branch June 13, 2019 02:12
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants