Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to Pandas 1.3.0 and LightGBM 3.2.1 #362

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

V1NAY8
Copy link
Contributor

@V1NAY8 V1NAY8 commented Jul 18, 2021

Closes #248,#359

@sethmlarson / @stevedodson Please review :)

Ask jenkins to test this.

@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible we should support pandas 1.2.0 and 1.3.0. I left some suggestions on how we can do this. We should also test against both 1.2.0 and 1.3.0 if possible, might require some changes to our CI?

eland/etl.py Show resolved Hide resolved
eland/etl.py Show resolved Hide resolved
eland/etl.py Outdated Show resolved Hide resolved
eland/plotting/_matplotlib/hist.py Outdated Show resolved Hide resolved
requirements-dev.txt Outdated Show resolved Hide resolved
@V1NAY8 V1NAY8 requested a review from sethmlarson July 19, 2021 13:48
@sethmlarson
Copy link
Contributor

jenkins test this please

noxfile.py Outdated Show resolved Hide resolved
eland/common.py Outdated Show resolved Hide resolved
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Here's a few comments for you:

eland/etl.py Outdated Show resolved Hide resolved
eland/etl.py Show resolved Hide resolved
eland/etl.py Outdated Show resolved Hide resolved
eland/etl.py Outdated Show resolved Hide resolved
@sethmlarson
Copy link
Contributor

jenkins test this please

1 similar comment
@sethmlarson
Copy link
Contributor

jenkins test this please

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, only one change for you then I'll merge:

eland/etl.py Outdated Show resolved Hide resolved
@sethmlarson
Copy link
Contributor

@V1NAY8 Can you rebase this on master?

@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Jul 26, 2021

Ok,
Rebase is done. Lets see what jenkins says
so some jupyter notebook tests will fail for 1.3.0, You want me to fix them in this PR itself ?

@sethmlarson
Copy link
Contributor

@V1NAY8 Yeah you can fix the notebook tests, thanks!

@sethmlarson
Copy link
Contributor

jenkins test this please

@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Jul 27, 2021

@sethmlarson Notebook tests are all good. All the tests are passed. Also Pandas doesnt support 3.6. Only that failed.
Is it okay to get merged ?

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethmlarson sethmlarson merged commit 193bcb7 into elastic:master Jul 27, 2021
@V1NAY8 V1NAY8 deleted the pandas_lightgbm branch July 31, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify support of LightGBM v3
3 participants