Add type hints to core modules #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins test this please |
|
Ask Jenkins to test this. |
|
jenkins test this please |
1 similar comment
|
jenkins test this please |
|
Thanks, CI is good |
sethmlarson
suggested changes
Jul 29, 2021
eland/operations.py
Outdated
| @@ -947,7 +984,7 @@ def aggs_groupby( | |||
| @staticmethod | |||
| def bucket_generator( | |||
| query_compiler: "QueryCompiler", body: "Query" | |||
| ) -> Generator[List[str], None, List[str]]: | |||
| ) -> Generator[Sequence[Any], None, Sequence[Any]]: | |||
There was a problem hiding this comment.
We should try to keep this type Generator[Sequence[str], None, Sequence[str]]
There was a problem hiding this comment.
[{'key': {'groupby_Cancelled': False}, 'doc_count': 11381, 'sum_dayOfWeek': {'value': 32242.0}, 'sum_FlightDelayMin': {'value': 536325.0}, 'sum_AvgTicketPrice': {'value': 7162656.040748596}}, {'key': {'groupby_Cancelled': True}, 'doc_count': 1678, 'sum_dayOfWeek': {'value': 4793.0}, 'sum_FlightDelayMin': {'value': 81825.0}, 'sum_AvgTicketPrice': {'value': 1041708.8814849854}}]
So actually its Sequence[Dict[str, Any]]
When I initially wrote it , type wasn't correct
|
jenkins test this please |
sethmlarson
approved these changes
Aug 2, 2021
|
Thank You so much!! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.