Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Buildkite pipeline to push Docker image #613

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Oct 3, 2023

Closes #407

Here's a successful build: https://buildkite.com/elastic/eland-release-docker/builds/9#018af52e-7ca0-4e9c-8aa5-6fd9cd4348de. This also reintroduces #586, using a slim Debian 12 base image, which will greatly reduce the noise from vulnerability scanners.

I've left #600 as future work.

@pquentin pquentin added the ci issues related to continuous integration label Oct 3, 2023
@pquentin pquentin requested a review from ezimuel October 3, 2023 11:13
Copy link
Contributor

@ezimuel ezimuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pquentin
Copy link
Member Author

pquentin commented Oct 3, 2023

So the lint runs with the latest Python, which as of yesterday is Python 3.12. While we could use Python 3.10 instead (the latest version we support), the lint errors do make sense and the fixes work in Python 3.8+. For the record:

  • Python 3.12 has improved f-string support, which apparently allowed flake8 to detect indentation errors in f-strings: e968cd6 (#613)
  • Python 3.12 removed the distutils module that we were using to compare versions, this should be done with the third-party packaging model now: 1dbe81d (#613)

@pquentin pquentin merged commit 352e31e into main Oct 3, 2023
4 checks passed
@pquentin pquentin deleted the push-docker-image branch October 3, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci issues related to continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push eland Docker images with every version release
2 participants