Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keystore secrets parsing when values contain commas. #50

Merged
merged 4 commits into from
May 20, 2022

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented May 19, 2022

The next step in fixing elastic/beats#29789 after elastic/go-ucfg#192

Update go-ucfg to allow disabling the interpretation of commas when parsing values loaded from the keystore. Adds a regression test that reproduces the problem by testing with a secret value that contains every special character instead of a basic string.

The next step will be updating this dependency in beats to actually fix the problem there.

@cmacknz cmacknz added the bug Something isn't working label May 19, 2022
@cmacknz cmacknz requested a review from a team as a code owner May 19, 2022 19:02
@cmacknz cmacknz self-assigned this May 19, 2022
@cmacknz cmacknz requested review from belimawr and kvch and removed request for a team May 19, 2022 19:02
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-19T19:02:20.618+0000

  • Duration: 8 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 710
Skipped 5
Total 715

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@kvch kvch merged commit d82b6d0 into elastic:main May 20, 2022
@cmacknz cmacknz deleted the fix-keystore-secrets-parsing branch May 20, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants