Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move registry used by handles processor #37

Merged

Conversation

fearful-symmetry
Copy link
Contributor

What does this PR do?

Fix for a bug reported by @cmacknz where the migration process of metrics from libbeat to here also changed the location of the handles monitoring metrics. This changes it back from "system" to "beat". We don't have any tests here, so a tad hard to validate this until it makes its way up to the beats repo again.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

@fearful-symmetry fearful-symmetry added bug Something isn't working Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Jun 29, 2022
@fearful-symmetry fearful-symmetry self-assigned this Jun 29, 2022
@fearful-symmetry fearful-symmetry requested a review from a team as a code owner June 29, 2022 20:27
@fearful-symmetry fearful-symmetry requested review from faec and removed request for a team June 29, 2022 20:27
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 29, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-29T21:57:41.246+0000

  • Duration: 46 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 167
Skipped 3
Total 170

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@fearful-symmetry
Copy link
Contributor Author

/test

Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to update the dependency in the branch for elastic/beats#32153, the tests there reproduce the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants