Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the context cancelled error message into a debug statement #187

Merged
merged 4 commits into from
Mar 16, 2022

Conversation

ph
Copy link
Contributor

@ph ph commented Mar 9, 2022

This code improve the error reporting when Elastic Agent is stopped
through the pass context. This move the state reporting closer to the
execution of the request. Error related to the request would still be
logged as error and will change the internal state to non healthy.

Fixes: #154

This code improve the error reporting when Elastic Agent is stopped
through the pass context. This move the state reporting closer to the
execution of the request. Error related to the request would still be
logged as error and will change the internal state to non healthy.

Fixes: elastic#154
@ph ph added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Mar 9, 2022
@ph ph self-assigned this Mar 9, 2022
@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2022

This pull request does not have a backport label. Could you fix it @ph? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label Mar 9, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 9, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-16T16:58:31.489+0000

  • Duration: 31 min 29 sec

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify mergify bot removed the backport-skip label Mar 10, 2022
@jlind23 jlind23 requested a review from a team March 10, 2022 14:30
@ph ph added the ci:end-to-end Enable the e2e-testing label Mar 10, 2022
@ph
Copy link
Contributor Author

ph commented Mar 10, 2022

@narph I believe the ci:end-to-end label would trigger a CI Job, but I don't see the end to end test name in the list of job run for this PR.

@ph ph requested a review from blakerouse March 15, 2022 13:16
@narph
Copy link
Contributor

narph commented Mar 16, 2022

run end-to-end tests

@narph
Copy link
Contributor

narph commented Mar 16, 2022

@narph I believe the ci:end-to-end label would trigger a CI Job, but I don't see the end to end test name in the list of job run for this PR.

it requires to run a build to enable it, looks like my comment triggered the tests

@ph
Copy link
Contributor Author

ph commented Mar 16, 2022

/test

@ph
Copy link
Contributor Author

ph commented Mar 16, 2022

let's see if a manual trigger show this.

@ph
Copy link
Contributor Author

ph commented Mar 16, 2022

@narph @v1v seems we cannot retrieve the filebeat artifacts?

@ph
Copy link
Contributor Author

ph commented Mar 16, 2022

Probably because of the artifact api issues.

@v1v
Copy link
Member

v1v commented Mar 16, 2022

@narph @v1v seems we cannot retrieve the filebeat artifacts?

Maybe the release platform team might know if something is down in the artifacts-api?

@narph
Copy link
Contributor

narph commented Mar 16, 2022

@narph @v1v seems we cannot retrieve the filebeat artifacts?

Maybe the release platform team might know if something is down in the artifacts-api?

Just saw an email regarding an outage (redacted the issue which points to an internal repo)

@ph
Copy link
Contributor Author

ph commented Mar 16, 2022

/test

@ph
Copy link
Contributor Author

ph commented Mar 16, 2022

Yes this is probably due to the artifact outage.

@ph ph merged commit ca443e0 into elastic:main Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.2.0 ci:end-to-end Enable the e2e-testing Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
5 participants